DPE-904 Fixing Juju SDK warning: SIMULATE_CAN_CONNECT=True #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taurus-forever
requested review from
shayancanonical,
paulomach and
carlcsaposs-canonical
shayancanonical
approved these changes
Dec 5, 2022
carlcsaposs-canonical
approved these changes
Dec 6, 2022
taurus-forever
force-pushed
the
alutay/fix-warning-SIMULATE_CAN_CONNECT
branch
from
6e67a56 to
299d32d
Compare
> ========================= warnings summary ================ > ... > tests/unit/test_charm.py::TestCharm::test_on_leader_elected_create_exception > tests/unit/test_charm.py::TestCharm::test_on_leader_elected_create_existing_service > tests/unit/test_charm.py::TestCharm::test_on_peer_relation_created > tests/unit/test_charm.py::TestCharm::test_on_peer_relation_created_delete_exception > tests/unit/test_charm.py::TestCharm::test_on_peer_relation_created_delete_nothing > /home/taurus/canonical/mysql-router-k8s-operator/.tox/unit/lib/python3.10/site-packages/ops/testing.py:190: > UserWarning: Please set ops.testing.SIMULATE_CAN_CONNECT=True. > See https://juju.is/docs/sdk/testing#heading--simulate-can-connect for details. > warnings.warn( > > -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
taurus-forever
force-pushed
the
alutay/fix-warning-SIMULATE_CAN_CONNECT
branch
from
76d19d3 to
e72ccaf
Compare
taurus-forever
requested review from
shayancanonical and
carlcsaposs-canonical
shayancanonical
approved these changes
Jan 3, 2023
carlcsaposs-canonical
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
It is a side effect fix in DPE-904 to address annoying warning.
Solution
Use SIMULATE_CAN_CONNECT=True as recommended by Juju SDK.
Context
Just a warning fix, should have no other effect.
Release Notes
Juju testing SDK: use SIMULATE_CAN_CONNECT=True for better connection tracking.
Testing
Just a warning fix, should have no other effect.