Address PR feedback

canonical · Oct 23, 2023 · 86e8516 · 86e8516
1 parent 672badd
commit 86e8516
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/src/kubernetes_logrotate.py b/src/kubernetes_logrotate.py
@@ -19,7 +19,6 @@ class LogRotate(logrotate.LogRotate):
 
     def __init__(self, *, container_: container.Container):
         super().__init__(container_=container_)
-        self._logrotate_config = self._container.path("/etc/logrotate.d/flush_mysqlrouter_logs")
         self._logrotate_executor = self._container.path("/logrotate_executor.py")
 
     def enable(self) -> None:

diff --git a/src/logrotate.py b/src/logrotate.py
@@ -7,10 +7,10 @@
 """
 
 import abc
+import logging
 import pathlib
 
 import jinja2
-import logging
 
 import container
 
@@ -25,6 +25,8 @@ class LogRotate(abc.ABC):
     def __init__(self, *, container_: container.Container):
         self._container = container_
 
+        self._logrotate_config = self._container.path("/etc/logrotate.d/flush_mysqlrouter_logs")
+
     def enable(self) -> None:
         """Enable logrotate."""
         logger.debug("Creating logrotate config file")

diff --git a/src/rock.py b/src/rock.py
@@ -90,7 +90,6 @@ def update_mysql_router_service(self, *, enabled: bool, tls: bool = None) -> Non
             startup = ops.pebble.ServiceStartup.DISABLED.value
         layer = ops.pebble.Layer(
             {
-                "summary": "MySQL Router layer",
                 "services": {
                     self._SERVICE_NAME: {
                         "override": "replace",
@@ -124,7 +123,6 @@ def update_logrotate_executor_service(self, *, enabled: bool) -> None:
         )
         layer = ops.pebble.Layer(
             {
-                "summary": "Logrotate executor layer",
                 "services": {
                     self._LOGROTATE_EXECUTOR_SERVICE_NAME: {
                         "override": "replace",