DPE-2662 single unit upgrade fixes #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #340 +/- ##
==========================================
- Coverage 64.50% 64.47% -0.04%
==========================================
Files 17 17
Lines 3113 3127 +14
Branches 413 415 +2
==========================================
+ Hits 2008 2016 +8
- Misses 979 983 +4
- Partials 126 128 +2
|
paulomach
requested review from
carlcsaposs-canonical,
taurus-forever and
shayancanonical
taurus-forever
previously approved these changes
Oct 13, 2023
we start seeing errors due to no space left on device
carlcsaposs-canonical
approved these changes
Oct 16, 2023
Comment on lines
+136
to
+138
| - name: Free space in runner | ||
| run: | | ||
| # free space in the runner |
There was a problem hiding this comment.
Suggested change
| - name: Free space in runner | |
| run: | | |
| # free space in the runner | |
| - name: Free up disk space | |
| run: | | |
| # From https://github.com/actions/runner-images/issues/2840#issuecomment-790492173 |
nit
| self.set_unit_completed() | ||
| # ensures leader gets it's own relation-changed when it upgrades | ||
| if self.charm.unit.is_leader(): | ||
| logger.debug("Re-emitting upgrade-changed on leader...") |
There was a problem hiding this comment.
nit: "emitting" is a bit confusing since we're not ops.emiting an event, but just calling the handler (e.g. if the handler calls event.defer it's not deferring upgrade_changed)
taurus-forever
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Solution
reboot_from_complete_outagefor single unit deployment recovery