Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor nit to not re-enable sql_log_bin + free disk space on gh runner before running tests #339

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

shayancanonical
Copy link
Contributor

Issue

  1. We are re-enabling sql_log_bin in flush_mysql_logs() when there is no need - the variable is only valid for the session
  2. We are running out of disk space when running CI (see the following run)

Solution

  1. Prevent re-enabling the variable
  2. Free disk space on GH runner before running the tests

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #339 (89583f3) into main (1f72f1b) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #339   +/-   ##
=======================================
  Coverage   64.50%   64.50%           
=======================================
  Files          17       17           
  Lines        3113     3113           
  Branches      413      413           
=======================================
  Hits         2008     2008           
  Misses        979      979           
  Partials      126      126           
Files Coverage Δ
lib/charms/mysql/v0/mysql.py 73.22% <100.00%> (ø)

Comment on lines +116 to +120
- name: Free disk space
run: |
echo "Free disk space before cleanup"
df -T
# free space in the runner
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Free disk space
run: |
echo "Free disk space before cleanup"
df -T
# free space in the runner
- name: Free up disk space
run: |
echo "Free disk space before cleanup"
df -T
# From https://github.com/actions/runner-images/issues/2840#issuecomment-790492173

nit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will commit nit in the next PR to avoid rerunning tests

@shayancanonical shayancanonical merged commit 7e3c405 into main Oct 18, 2023
@shayancanonical shayancanonical deleted the fix/sql_log_bin_reenable branch October 18, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants