Remove unneeded parametrization for series fixture #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlcsaposs-canonical
requested review from
paulomach,
taurus-forever and
shayancanonical
|
Changes extracted from #101 (WIP) |
|
Why it was created in the first place? |
Not sure, my guess is that using a fixture wasn't obvious or the idea was to later support running tests on multiple series in a single pytest command. It looks like @shayancanonical added it in #61 |
|
@carlcsaposs-canonical is correct. the idea of using a fixture wasnt completely obvious to me when i made the change |
shayancanonical
approved these changes
Feb 2, 2023
carlcsaposs-canonical
force-pushed
the
refactor/series-fixture
branch
from
21a0b86 to
bdcc514
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.