Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tox.ini #100

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Update tox.ini #100

merged 2 commits into from
Feb 7, 2023

Conversation

carlcsaposs-canonical
Copy link
Contributor

@carlcsaposs-canonical carlcsaposs-canonical commented Jan 30, 2023 •
edited
Loading

@carlcsaposs-canonical carlcsaposs-canonical marked this pull request as draft January 30, 2023 21:04
taurus-forever
taurus-forever previously approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb!

@carlcsaposs-canonical carlcsaposs-canonical force-pushed the chore/update-tox-file branch 2 times, most recently from 8a49f06 to 33049f8 Compare January 31, 2023 13:29
@carlcsaposs-canonical carlcsaposs-canonical marked this pull request as ready for review January 31, 2023 15:10
@carlcsaposs-canonical carlcsaposs-canonical mentioned this pull request Jan 31, 2023
Closed
@carlcsaposs-canonical carlcsaposs-canonical marked this pull request as draft January 31, 2023 20:30
@carlcsaposs-canonical carlcsaposs-canonical marked this pull request as ready for review January 31, 2023 21:04
@carlcsaposs-canonical
Copy link
Contributor Author

@taurus-forever @shayancanonical Waiting for re-review. Pinging in case original notification didn't go through

taurus-forever
taurus-forever approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx!

@carlcsaposs-canonical carlcsaposs-canonical merged commit dbde8df into main Feb 7, 2023
@carlcsaposs-canonical carlcsaposs-canonical deleted the chore/update-tox-file branch February 7, 2023 12:20
carlcsaposs-canonical added a commit to canonical/mysql-k8s-operator that referenced this pull request Feb 15, 2023
@carlcsaposs-canonical
Cache charmcraft pack container, skip unstable tests except on sche…
faf4c1a 
…dule

Ported from:
canonical/mysql-operator#78
canonical/mysql-operator#88
canonical/mysql-operator#87
canonical/mysql-operator#100
@carlcsaposs-canonical carlcsaposs-canonical mentioned this pull request Feb 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shayancanonical shayancanonical shayancanonical approved these changes

@taurus-forever taurus-forever taurus-forever approved these changes

@paulomach paulomach Awaiting requested review from paulomach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlcsaposs-canonical @taurus-forever @shayancanonical