-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-6347] full replica set tf #380
Merged
Merged
+37
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mehdi-Bendriss
previously approved these changes
Jan 20, 2025
Gu1nness
reviewed
Jan 20, 2025
Gu1nness
reviewed
Jan 20, 2025
Gu1nness
previously approved these changes
Jan 23, 2025
Co-authored-by: Neha Oudin <[email protected]>
Gu1nness
approved these changes
Jan 23, 2025
Mehdi-Bendriss
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Missing all possible integrations for replica sets
Solution
Add in all remaining integrations
Other
Fo mongodb VM terraform we integrate with
grafana-agent
as it is a requirement of the spec. However, VM charms do not integrate withgrafana-agent
. Instead they expose COS endpoints for loki, prometheus, and grafana-dashboards. The spec specifies that complete solutions for terraform bundles should expose these endpoints, so there is nothing for us to add here