-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create k8s_service_info library #3
Conversation
This library provides functionality for sharing Kubernetes Service information using the k8s-service relation interface. This commit adds the library and unit tests. Fixes #2
d1074e0
to
f8c17c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick pass too and left some minor comments.
Should we add some basic repo settings to this regarding merging and protection? Since this is something our charms will use. I see
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some comments but generally looks promising!
Good catch, I have added a branch protection rule for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some more review comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few things to look into as comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small thing in the tests, otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! ty @DnPlas!
This library provides functionality for sharing Kubernetes Service information using the k8s-service relation interface. Please refer to #2 for details.
Fixes #2