Set status to Blocked when secret-key is shorter than 8 characters long #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lucabello I created #183 that introduces the changes you made (to trigger the CI because it only triggers for team members of the repo). Great work! |
|
@lucabello Since all the CI passes, it's ready to go! Some small suggestions before we merge:
Thanks again! |
|
Seems like you have your other PR up so not sure if you still need this one, but updating the things you asked nonetheless :) |
lucabello
changed the title
mvlassis
approved these changes
Aug 13, 2024
|
@lucabello I created the PR just to trigger the CI, so I just merged yours and closed #183 as a duplicate. Thanks for contributing :) |
orfeas-k
pushed a commit
that referenced
this pull request
Nov 19, 2024
orfeas-k
added a commit
that referenced
this pull request
Nov 20, 2024
…ngth backport(fix): block when secret-key is too short from #178
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #137.
This PR adds an additional check in the charm.py file to ensure that the
secret-keyis at least 8 characters long. If it isn't, the charm's status changes to blocked with an appropriate message.The minimum size of 8 characters seems to be hard-coded in this line.