fix: Pin Prometheus and Grafana revisions #82
Conversation
phoevos
force-pushed
the
kf-4278-pin-prometheus-rev
branch
from
f47e7dc
to
0d31711
Compare
|
@phoevos was not it the intend to bump all KF charms to juju 3.1 ? why do we pull prometheus from edge and not from stable? |
@beliaev-maksim, yes we will be bumping all charms to 3.1 shortly. However, this is now breaking our CI across our repos, which is blocking patches required for the time-critical airgapped effort. Therefore, the idea was to patch this now, pinning to a version we know works, and revert it as soon as we've moved to Juju 3.1 In general, I do believe that we should be using third-party charms from some stable channel. However, in this case it won't make a difference, since the o11y team plan to bump stable very soon. |
|
@phoevos but then once they bump we need to revert to stable on our side Why use it then in the first place? Or does current stable cause issues? |
|
@beliaev-maksim, the current stable is fine. I'd say let's just upgrade to Juju 3.1 first, and then we can go through the third-party charms we're deploying as part of our integration tests and make sure that we always pull from a stable channel. |
|
Well, Will leave it to others |
|
@beliaev-maksim, note that we'll probably have to do the same for Grafana as well, so I'll be repurposing this PR: |
|
@phoevos okay! |
This is a temporary patch until we migrate to Juju 3.1: * Pin Prometheus revision when deploying from `latest` to avoid fetching recent patches of the charm which assume `juju >= 3.0.3`. Revision 137 was the last one seen working properly in our CI integration tests. * Pin Grafana revision when deploying from `latest` to avoid fetching recent patches of the charm which fail to install on Juju 2.9. Revision 89 was the last one working properly in our CI integration tests. Signed-off-by: Phoevos Kalemkeris <[email protected]>
phoevos
force-pushed
the
kf-4278-pin-prometheus-rev
branch
from
cb8d616
to
17178d8
Compare
phoevos
changed the title
This is a temporary patch until we migrate to Juju 3.1: * Pin Prometheus revision when deploying from `latest` to avoid fetching recent patches of the charm which assume `juju >= 3.0.3`. Revision 137 was the last one seen working properly in our CI integration tests. * Pin Grafana revision when deploying from `latest` to avoid fetching recent patches of the charm which fail to install on Juju 2.9. Revision 89 was the last one working properly in our CI integration tests. Signed-off-by: Phoevos Kalemkeris <[email protected]>
backport(fix): Pin Prometheus and Grafana revisions (#82)
This is a temporary patch until we migrate to Juju 3.1:
latestto avoid fetching recent patches of the charm which assumejuju >= 3.0.3. Revision 137 was the last one seen working properly in our CI integration tests.latestto avoid fetching recent patches of the charm that fail to install on Juju 2.9. Revision 89 was the last one working properly in our CI integration tests.Refs canonical/bundle-kubeflow#688
Refs canonical/bundle-kubeflow#690