Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add cypress docs/api test #786

Merged
merged 3 commits into from
Jul 18, 2023
Merged

test: add cypress docs/api test #786

merged 3 commits into from
Jul 18, 2023

Conversation

petermakowski
Copy link
Contributor

Done

  • add cypress docs/api test

@webteam-app
Copy link

Demo starting at https://maas-io-786.demos.haus

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #786 (4fc3d1d) into main (5d1b71b) will not change coverage.
The diff coverage is n/a.

❗ Current head 4fc3d1d differs from pull request most recent head b1b07f3. Consider uploading reports for the commit b1b07f3 to get more accurate results

@@           Coverage Diff           @@
##             main     #786   +/-   ##
=======================================
  Coverage   61.65%   61.65%           
=======================================
  Files           8        8           
  Lines         193      193           
=======================================
  Hits          119      119           
  Misses         74       74           
Flag Coverage Δ
python 61.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ndv99
Copy link
Collaborator

ndv99 commented May 17, 2023

I think we need to update the node version used here, seems as though it's failing since Cypress requires >v14 and the runner is using 12

@petermakowski petermakowski marked this pull request as ready for review May 18, 2023 11:04
Copy link
Collaborator

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, but the CI is still failing (test-python), not quite sure why

@petermakowski petermakowski requested a review from ndv99 July 18, 2023 08:12
@petermakowski petermakowski force-pushed the add-cypress branch 3 times, most recently from b86e540 to 0994e3a Compare July 18, 2023 08:21
@petermakowski petermakowski merged commit 3fe33be into main Jul 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants