Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert jquery to 3.4.1 #988

Merged
merged 2 commits into from
Apr 17, 2020
Merged

Revert jquery to 3.4.1 #988

merged 2 commits into from
Apr 17, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

Done

QA

  • Checkout master, clean your node_modules (yarn clean-all or dotrun clean) and run
  • Confirm that node details, devices list, and controllers list are all broken with warning icons.
  • Checkout this branch and clean your node_modules and run again
  • Confirm that the node details, devices list and controllers list look normal

Fixes

Fixes #977

squidsoup
squidsoup approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@squidsoup squidsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find @Caleb-Ellis, that appears to have fixed it!

@Caleb-Ellis Caleb-Ellis merged commit a294685 into canonical:master Apr 17, 2020
@Caleb-Ellis Caleb-Ellis deleted the revert-jquery branch April 17, 2020 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squidsoup squidsoup squidsoup approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Angular views are displaying as warning icons
2 participants
@Caleb-Ellis @squidsoup