Add guards to node details networking functions. #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squidsoup
approved these changes
Apr 17, 2020
There was a problem hiding this comment.
Thanks @Caleb-Ellis. Looks good, although we should probably fix the GA handler 👀
| @@ -2277,7 +2277,7 @@ <h2 class="p-heading--four">Create bond</h2> | |||
|
|
|||
| <button class="p-button--neutral" data-ng-click="toggleInterfaces()" data-ng-if="showCreateEditButton()"> | |||
| <span data-ng-if="isShowingInterfaces">Hide interfaces</span> | |||
| <span data-ng-if="!isShowingInterfaces" data-ng-click="Network table', Edit bond')">Edit bond members</span> | |||
There was a problem hiding this comment.
We should probably preserve this GA handler, so I guess it should be (most of the examples of calling this function in our code are wrong unfortunately...):
data-ng-click="sendAnalyticsEvent('bond', 'edit', 'network table')"
There was a problem hiding this comment.
Actually, let's keep this consistently wrong, until we do our total GA fixup, so this should be
sendAnalyticsEvent('Machine details', 'Edit bond', 'Network tab')
squidsoup
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
type is not definedone a couple of times, each after marking an interface as connected or disconnected. So I'm not sure... click around on all the different buttons, add/delete interfaces, bridges, bonds... and check that you don't get any errors in the console?Fixes
Fixes #892
Fixes #893