Batch load machines #958
Merged
Batch load machines #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squidsoup
approved these changes
Apr 8, 2020
| @@ -2,6 +2,19 @@ import { createStandardActions } from "app/utils/redux"; | |||
|
|
|||
| const machine = createStandardActions("machine"); | |||
|
|
|||
| machine.fetch = () => { | |||
There was a problem hiding this comment.
I don't think redefining this action is necessary, limit can be passed to machine.fetch as params and it should DTRT. createStandardActions should be updated to take params like the other actions. The components dispatching the action can then define the limits themselves.
Closed
huwshimi
force-pushed
the
handle-batch-requests
branch
from
079ffa1 to
47c182a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
Fixes
Fixes: #919.
Fixes: https://github.com/canonical-web-and-design/MAAS-squad/issues/1871.