Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build set pool form in action menu. #891

Merged
merged 2 commits into from
Apr 2, 2020
Merged

Build set pool form in action menu. #891

merged 2 commits into from
Apr 2, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

@Caleb-Ellis Caleb-Ellis commented Mar 11, 2020 •
edited
Loading

Done

QA

  • Select some machines and choose "Set resource pool..." from the action menu
  • Check that you can set the machines' pools to it

Fixes

Fixes canonical-web-and-design/MAAS-squad#1789

Screenshot

Screenshot_2020-04-01 Machines karura MAAS

@huwshimi
Copy link
Contributor

Looks like this one is still WIP.

@huwshimi
Copy link
Contributor

@Caleb-Ellis let's chat about the update flow when you get back.

@Caleb-Ellis Caleb-Ellis force-pushed the set-pool-form branch 2 times, most recently from 4a38ede to f9e7096 Compare April 1, 2020 05:28
@Caleb-Ellis Caleb-Ellis changed the title WIP: Build set pool form in action menu. Build set pool form in action menu. Apr 1, 2020
@Caleb-Ellis Caleb-Ellis merged commit 8555f20 into canonical:master Apr 2, 2020
@Caleb-Ellis Caleb-Ellis deleted the set-pool-form branch April 2, 2020 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huwshimi huwshimi huwshimi approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Caleb-Ellis @huwshimi @anthonydillon @cristinadresch