Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of local storage for config in angular app. #628

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Remove usage of local storage for config in angular app. #628

merged 1 commit into from
Jan 9, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

@Caleb-Ellis Caleb-Ellis commented Jan 8, 2020 •
edited
Loading

Done

  • Removed usage of local storage for config in angular app

QA

  • Log in to create a session cookie and then close the tab (don't log out)
  • Log in from a private window, and change the name of the user and then log out
  • Open another MAAS tab (you shouldn't need to log in because the session is still valid) and check that the updated name is correctly shown in the top right
  • Create a new user
  • Log in as them and check that the intro page loads

Fixes

Fixes #625

squidsoup
squidsoup approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@squidsoup squidsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @Caleb-Ellis

@squidsoup squidsoup merged commit cc8202a into canonical:master Jan 9, 2020
@Caleb-Ellis Caleb-Ellis deleted the remove-config-local-storage branch January 9, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squidsoup squidsoup squidsoup approved these changes

Assignees

@squidsoup squidsoup

Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove usage of local storage for config in angular app
2 participants
@Caleb-Ellis @squidsoup