Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly highlight the nav item for the legacy app. #616

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Correctly highlight the nav item for the legacy app. #616

merged 1 commit into from
Jan 6, 2020

Conversation

huwshimi
Copy link
Contributor

@huwshimi huwshimi commented Jan 6, 2020

Done

  • Update the header when the nav changes.
  • Correctly match the URL against the hash.

QA

  • Load the legacy app.
  • Click through a few items in the top nav. The current page should be highlighted.
  • Do the same for the React app.

Fixes

Fixes: #615.

squidsoup
squidsoup approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@squidsoup squidsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @huwshimi.

@huwshimi huwshimi merged commit b544cf5 into canonical:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squidsoup squidsoup squidsoup approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Current nav item not selected for legacy
2 participants
@huwshimi @squidsoup