Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LP: #1856772 - Fix install KVM checkbox. #600

Merged
merged 1 commit into from
Dec 19, 2019
Merged

LP: #1856772 - Fix install KVM checkbox. #600

merged 1 commit into from
Dec 19, 2019

Conversation

Caleb-Ellis
Copy link
Contributor

Done

  • Fixed install KVM checkbox in Deploy dropdown not working correctly. I think it was missed in one of the migrations from launchpad to github.

QA

  • In the machine list, open the Deploy action dropdown and check that the checkbox is disabled for all OSes that aren't 18.04 or 20.04.
  • Check that the form actually sends the information to MAAS (add console.log(extra) to legacy/src/app/factories/nodes.js L32).
  • Do the same on the machine details page.

Fixes

Fixes #599.

Launchpad Issue

lp#1856772.

steverydz
steverydz approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Caleb-Ellis Caleb-Ellis merged commit e00c90b into canonical:master Dec 19, 2019
@Caleb-Ellis Caleb-Ellis deleted the fix-kvm-install-option branch December 19, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steverydz steverydz steverydz approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to register KVM Pod on deployment
2 participants
@Caleb-Ellis @steverydz