Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LP: #1832176 - Fix release-options directive not adopting defaults correctly #598

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

Caleb-Ellis
Copy link
Contributor

@Caleb-Ellis Caleb-Ellis commented Dec 19, 2019

Done

  • Moved inline markup in release-options directive to its own partial.
  • Renamed a few variables to be clearer (maasReleaseOptions => localOptions, erase => enableDiskErasing).
  • Config is now explicitly loaded on directive render. Previously, it was assumed that the config had already been loaded, so refreshing on the node details page would return incorrect config values (i.e. nothing). This also means that a spinner will display when the release dropdown is opened.
  • Also fixed a bug where extra parameters weren't actually getting passed to the websocket handler. LOL

QA

  • Select multiple machines and choose Release from the action menu, and check that the checkboxes correctly reflect what's set in Settings > Storage. Note that if "Enable disk erasing" is set to true in Settings, the checkbox in the dropdown is disabled and permanently checked by design due to the way the release_or_erase method works in the backend. This took me a liiiittle while to realise that it wasn't a bug that disks were always erased even when the dropdown checkbox suggested otherwise >_>
  • Check that running Release actually does what it's supposed to do, e.g. if erase is not selected the node goes straight to "Releasing..." state. If it is selected, the node goes to "Disk erasing..." state.
  • Do the same in the node details page.

Fixes

Fixes #562.

Launchpad Issue

lp#1832176.

Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quick erase by default when erasing disks does not work
2 participants