Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add weekly coverage run to Ci, publish to GitHub pages, create and upload TiCS report #5570

Merged
merged 17 commits into from
Jan 6, 2025

Conversation

tmerten
Copy link
Collaborator

@tmerten tmerten commented Dec 20, 2024

Done

  • remove coverage runs from test.yaml as we do not want to involve a full TiCS measurement on every MP/push
  • add coverage runs to their own coverage.yaml job
    • add cronjob to run this weekly
    • add coverage run with istanbul, create cobertura compatible output in .coverage for TiCS
    • edit workflow so that less copying up-/and downloading is done
    • fix TiCS, make sure coverage is uploaded to https://canonical.github.io/maas-ui/
    • setup job so that a push to ci-tics-main is always provoking a run so that we can test things

QA steps

Fixes

Fixes: TiCS report, adds coverage

Screenshots

(see QA links above)

Notes

Do not merge before January 6th as Tiobe is updating their services and runs will fail or produce incorrect results

petermakowski and others added 17 commits August 21, 2024 13:34
- condense some targets in package.json as the in between stages have
  not been used
- add comment to vitest for istanbul coverage
- move coverage in own workflow
also add comment to schedule run
- artifact upload v3 will be deprecated on Dec 4th
- tics analyzer seems to have run in diagnostic mode, need to test in
  production (qserver/client) modes now
at least in client mode, probably not in qserver mode(?)
- move TiCS stuff into main test run to profit from checkout and PR info
- setup client vs qserver mode for test runs and qualifying runs
workflow name changed but did not update dependent workflow
TICS seems to need more than 360 minutes (6 Hours) which is the default for GitHub workers.
We bump this to 12 hours to align with the backend TICS runner, which we can reduce down if not needed.
make sure to write cobertura output to `.coverage/` so that
it is properly picked up by TiCS
- forgot to remove thresholds
- link step should not be needed anymore
@webteam-app
Copy link

@tmerten tmerten marked this pull request as ready for review January 6, 2025 10:54
@tmerten tmerten requested a review from ndv99 January 6, 2025 10:54
Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, glad to see this working!!

@ndv99 ndv99 merged commit 52960a1 into main Jan 6, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants