feat(machines): Add 'Power cycle' as a feature-flagged action MAASENG-3945 #5566
Conversation
Demo
Jenkins 
demos.haus - Added empty reducer for powerCycle action to machine state slice
| return formComponents[action](); | ||
| }; | ||
|
|
||
| const formComponents = { |
There was a problem hiding this comment.
You just translated the zen of python to JS. Explicit is better than implicit. Looks cleaner albeit being a little more code.
| return formComponents[action](); | ||
| }; | ||
|
|
||
| const formComponents = { |
There was a problem hiding this comment.
You just translated the zen of python to JS. Explicit is better than implicit. Looks cleaner albeit being a little more code.
There was a problem hiding this comment.
had some network glitches, sorry for the duplicates
| @@ -1,9 +1,13 @@ | |||
| import { isValidPortNumber } from "."; | |||
|
|
|||
| it("returns true for any number between 0 and 65535", () => { | |||
There was a problem hiding this comment.
Though shall not smuggle in unrelated changes in a PR.
(It's a good change and I can see it won't break things so let's merge it with this one)
| return formComponents[action](); | ||
| }; | ||
|
|
||
| const formComponents = { |
There was a problem hiding this comment.
You just translated the zen of python to JS. Explicit is better than implicit. Looks cleaner albeit being a little more code.
Done
VITE_APP_DPU_PROVISIONINGfeature flag to env (default:false)getFormComponentinMachineActionFormWrapperto an object of key-value pairs to reduce complexity*forloop test for valid ports with a handful of explicit test cases insrc/app/utils/isValidPortNumber.test.ts**QA steps
VITE_APP_DPU_PROVISIONING = trueto your.env.localFixes
Resolves MAASENG-3945
Screenshots
Notes
*Adding another
caseto the existing switch pushes the function over the complexity limit of 25.**I decided that this was probably a bit silly, even if it didn't take that long to run.