Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show msm connection info #5458

Merged
merged 4 commits into from
Jun 12, 2024
Merged

feat: show msm connection info #5458

merged 4 commits into from
Jun 12, 2024

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Jun 11, 2024 •
edited by jira bot
Loading

Done

Figma

https://www.figma.com/design/R4sX8oUJp1NWDg1t8o6YDr/Image-provisioning?node-id=519-27497&t=ywqadFRRtX1d9D8I-0

QA steps

  • Login and verify that "MAAS Site Manager Connected" message is not displayed
  • Open redux devtools
  • Dispatch an action below:
{
  type: 'msm/fetchSuccess',
  payload: {
    'sm-url': null,
    'start-time': null,
    running: 'connected'
  }
}
  • Verify that "MAAS Site Manager Connected" message is displayed
  • Verify that tooltip text is visible on hover and focus

Fixes

Fixes: MAASENG-2897

Screenshots

Google Chrome screenshot 001971@2x

Notes

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@petermakowski petermakowski force-pushed the feat-show-msm-connection-info-MAASENG-2897 branch from ffdd580 to 249bae7 Compare June 11, 2024 15:08
ndv99
ndv99 reviewed Jun 11, 2024
View reviewed changes
Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, just make sure you update the test snapshot for root reducer

@petermakowski petermakowski force-pushed the feat-show-msm-connection-info-MAASENG-2897 branch from 249bae7 to 730f1fb Compare June 12, 2024 12:30
@petermakowski petermakowski marked this pull request as ready for review June 12, 2024 12:45
@petermakowski petermakowski requested a review from ndv99 June 12, 2024 12:45
@petermakowski petermakowski force-pushed the feat-show-msm-connection-info-MAASENG-2897 branch from d1d3823 to 5cefb34 Compare June 12, 2024 12:46
@petermakowski petermakowski marked this pull request as draft June 12, 2024 12:48
@petermakowski petermakowski marked this pull request as ready for review June 12, 2024 12:54
@petermakowski
feat: show msm connection info
036513f 
Signed-off-by: Peter Makowski <[email protected]>
@petermakowski
fix: update strip-literal to 2.1.0
b588855 
- fixes vitest-dev/vitest#5387 (comment)

Signed-off-by: Peter Makowski <[email protected]>
@petermakowski
test: add rerender with state updates in renderWithMockStore
caa29c1 
- support rerendering components with updated immutable state with Immer `produce`.
- add `immer` as a dev dependency

Signed-off-by: Peter Makowski <[email protected]>
@petermakowski petermakowski force-pushed the feat-show-msm-connection-info-MAASENG-2897 branch 3 times, most recently from 3a438da to a4cffc1 Compare June 12, 2024 14:22
@petermakowski petermakowski force-pushed the feat-show-msm-connection-info-MAASENG-2897 branch from a4cffc1 to bae3c2b Compare June 12, 2024 14:24
ndv99
ndv99 approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermakowski petermakowski merged commit bbe685d into canonical:main Jun 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndv99 ndv99 ndv99 approved these changes

Assignees
No one assigned
Labels
Review: Code needed Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiline Vue component props breaks import.meta.env
3 participants
@petermakowski @webteam-app @ndv99