Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Create issue on sitespeed failure MAASENG-2176 #5170

Merged

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Sep 21, 2023

Done

  • Added failure condition to sitespeed.io workflow
  • Created universal CI failure issue template
  • Directed all non-PR workflows to use template

Fixes

Fixes MAASENG-2176

- Added failure condition to sitespeed.io workflow
- Created universal CI failure issue template
- Directed all non-PR workflows to use template
@webteam-app
Copy link

Demo starting at https://maas-ui-5170.demos.haus

Copy link
Contributor

@petermakowski petermakowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Could you test this before we merge?

You could create a separate branch based on this one.

Then add another commit updating one of the workflows to run on all branches and trigger a failure (e.g. by changing the basUrl in cypress workflow to an invalid url).

@@ -1,4 +1,4 @@
name: Upload
name: Build upload
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love these drive-by improvements, well done.

@ndv99
Copy link
Contributor Author

ndv99 commented Sep 21, 2023

@petermakowski ndv99#3 Run failed (on purpose), and the issue was created successfully!

@ndv99 ndv99 merged commit cec73b7 into canonical:main Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants