Fix broken links in network tab #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huwshimi
previously requested changes
Nov 7, 2019
| @@ -192,11 +192,11 @@ <h2 data-ng-click="snippetAddCancel()" class="u-float--left">Adding snippet</h2> | |||
| </div> | |||
| <ul class="p-inline-list--middot"> | |||
| <li class="p-inline-list__item" data-ng-if="!hideAllSnippetsLink"> | |||
| <a href="/#/settings/dhcp">All snippets: Settings > DHCP snippets</a> | |||
| <a href="/MAAS/r/settings/dhcp">All snippets: Settings > DHCP snippets</a> | |||
There was a problem hiding this comment.
Is it possible to use the env vars here to add the "/MAAS" and "/r" parts? In ./legacy/.env there should be two variables:
BASENAME="/MAAS"
REACT_BASENAME="/r"
There was a problem hiding this comment.
@huwshimi No, they don't work in the HTML templates
There was a problem hiding this comment.
Nevermind - I found a way :)
There was a problem hiding this comment.
Thanks for figuring that out! Looks great.
Caleb-Ellis
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Add correct
hrefvalues for the links to DHCP snippet settings and DHCP snippets docs on the network tab of a machine detail page. Fixes #396 and #392.QA
/MAAS/#/machinesactual-swine.maasqualifies)About DHCP snippetslink and see that you are taken to https://maas.io/docs/dhcp in a new tabAll snippets: Settings > DHCP snippetslink and see that you are taken to/MAAS/r/settings/dhcp