Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix broken width interpolation in KVM compose form #2073

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

Caleb-Ellis
Copy link
Contributor

Done

  • Fixed some broken width interpolation in KVM compose form. Turns out nesting #{}s doesn't work out too well.

QA

MAAS deployment

To run this branch you will need access to one of the following MAAS deployments:

Running the branch

You can run this branch by:

QA steps

  • Go to the details page of a KVM that has available subnets (e.g. bolla)
  • Open the Compose form from the action menu
  • Define an interface
  • Click the Subnet dropdown and check that the widths line up with the table columns
  • Check there are no errors in the console

Fixes

Fixes #2067

Copy link
Contributor

@squidsoup squidsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Caleb-Ellis Caleb-Ellis merged commit 1b17872 into canonical:master Jan 21, 2021
@Caleb-Ellis Caleb-Ellis deleted the kvm-width-fix branch January 21, 2021 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid calculated width value in KVM component
2 participants