fix(legacy): stop setting gateway on gateway-less subnets (#1860) #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Legacy 🧟♂️
Caleb-Ellis
reviewed
Dec 16, 2020
Caleb-Ellis
approved these changes
Dec 17, 2020
Caleb-Ellis
pushed a commit
that referenced
this pull request
Dec 17, 2020
) * fix(legacy): stop setting gateway on gateway-less subnets (#1860) Co-authored-by: Caleb Ellis <[email protected]>
Caleb-Ellis
pushed a commit
that referenced
this pull request
Dec 17, 2020
) * fix(legacy): stop setting gateway on gateway-less subnets (#1860) Co-authored-by: Caleb Ellis <[email protected]>
Caleb-Ellis
pushed a commit
that referenced
this pull request
Dec 17, 2020
) * fix(legacy): stop setting gateway on gateway-less subnets (#1860) Co-authored-by: Caleb Ellis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Unify the behavior for both standard and relayed networks, populating the placeholder with the suggested gateway without setting the IP when the subnet does not have one configured.
QA
Fixes
Fixes: #1860 .
Launchpad issue
lp#1903586
Backports
2.8 and 2.7 are affected too