Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add footer links to machine storage tab #1882

Merged
merged 1 commit into from
Nov 17, 2020
Merged

feat(ui): add footer links to machine storage tab #1882

merged 1 commit into from
Nov 17, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

Done

  • added footer links to machine storage tab + analytics event when clicking on the docs link

QA

MAAS deployment

To run this branch you will need access to one of the following MAAS deployments:

Running the branch

You can run this branch by:

QA steps

  • Go to the storage tab of a machine and check that the two links at the bottom are the same as in the angular version (except the react docs link doesn't need to redirect)

Fixes

Fixes canonical-web-and-design/MAAS-squad#2159

squidsoup
squidsoup approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@squidsoup squidsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Caleb-Ellis Caleb-Ellis merged commit b98af14 into canonical:master Nov 17, 2020
@Caleb-Ellis Caleb-Ellis deleted the storage-footer-links branch March 17, 2021 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squidsoup squidsoup squidsoup approved these changes

Assignees

@squidsoup squidsoup

Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Caleb-Ellis @squidsoup