-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete scripts #188
Delete scripts #188
Conversation
96c7dc3
to
aa1ef54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth adding some error handling e.g. if you remove a script from the old UI and then try to remove the same one from the new ui.
2516116
to
bb74fd0
Compare
After deleting the scripts, we see 0: |
Would it be too much to patch the side nav on small screens as a drive by?
|
We have a card for this one #184 |
@lilyvidenova that's not an error I've seen. A 504 would suggest that the MAAS server can't be reached. Do you have REACT_APP_BASE_URL configured in your |
Note
This is dependent on #183. Leaving this on WIP until 183's merged, to make this easier to review.
Done
QA