-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): differentiate analytics events for list and details pages #1845
feat(ui): differentiate analytics events for list and details pages #1845
Conversation
1f189b9
to
9c858b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Caleb-Ellis what's the difference between these events and onSaveAnalytics
in ActionForm? Does that one not fire at the right time?
9c858b7
to
457424e
Compare
457424e
to
13bc571
Compare
@Caleb-Ellis it looks like these events aren't being sent. The event gets fired when saved becomes true in FormikForm, but it doesn't look like that prop is being passed from ActionForm. |
13bc571
to
93ad92e
Compare
93ad92e
to
fb0b06f
Compare
Thanks @huwshimi that should be fixed now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Caleb-Ellis!
Done
QA
MAAS deployment
To run this branch you will need access to one of the following MAAS deployments:
Running the branch
You can run this branch by:
QA steps