Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): differentiate analytics events for list and details pages #1845

Merged
merged 2 commits into from
Nov 9, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

@Caleb-Ellis Caleb-Ellis commented Nov 6, 2020

Done

  • Send different category for GA events if in the details or list page
  • Added test factories to a bunch of form test files that don't actually help with anything, but they're leftovers from when I did this PR wrong the first time. :D

QA

MAAS deployment

To run this branch you will need access to one of the following MAAS deployments:

Running the branch

You can run this branch by:

QA steps

  • N/A

Copy link
Contributor

@huwshimi huwshimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Caleb-Ellis what's the difference between these events and onSaveAnalytics in ActionForm? Does that one not fire at the right time?

@Caleb-Ellis Caleb-Ellis force-pushed the action-form-analytics branch from 9c858b7 to 457424e Compare November 6, 2020 05:14
@Caleb-Ellis Caleb-Ellis changed the title feat(ui): add analytics to all machine action forms feat(ui): differentiate analytics events for list and details pages Nov 6, 2020
@Caleb-Ellis Caleb-Ellis force-pushed the action-form-analytics branch from 457424e to 13bc571 Compare November 6, 2020 05:17
@huwshimi huwshimi self-assigned this Nov 8, 2020
@huwshimi
Copy link
Contributor

huwshimi commented Nov 8, 2020

@Caleb-Ellis it looks like these events aren't being sent. The event gets fired when saved becomes true in FormikForm, but it doesn't look like that prop is being passed from ActionForm.

@Caleb-Ellis Caleb-Ellis force-pushed the action-form-analytics branch from 93ad92e to fb0b06f Compare November 9, 2020 00:43
@Caleb-Ellis
Copy link
Contributor Author

Thanks @huwshimi that should be fixed now 👍

Copy link
Contributor

@huwshimi huwshimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Caleb-Ellis!

@Caleb-Ellis Caleb-Ellis merged commit 3ef4e2d into canonical:master Nov 9, 2020
@Caleb-Ellis Caleb-Ellis deleted the action-form-analytics branch November 9, 2020 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants