feat(ui): add memory card to machine details overview #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squidsoup
force-pushed
the
add-memory-card
branch
from
0ed6025 to
bc296ba
Compare
Caleb-Ellis
reviewed
Nov 4, 2020
|
|
||
| <div className="overview-card__memory-tests u-flex--vertically"> | ||
| <ul className="p-inline-list u-no-margin--bottom" data-test="tests"> | ||
| {machine.memory_test_status.passed > 0 ? ( |
There was a problem hiding this comment.
Do you think this whole test traffic light thing could be extracted out into a component?
There was a problem hiding this comment.
Yep, I'll add a card for that
Caleb-Ellis
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
ui/src/app/machines/views/MachineDetails/MachineSummary/OverviewCard/MemoryCard/MemoryCard.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
-add memory card to machine details overview
QA
MAAS deployment
To run this branch you will need access to one of the following MAAS deployments:
Running the branch
You can run this branch by:
QA steps
Fixes
Fixes: # .
Launchpad issue
Related Launchpad maas issue in the form
lp#number.Backports
In general, please propose fixes against master rather than release branches (e.g. 2.7), unless the fix is only applicable for that specific release. Please apply backport labels to the PR (e.g. "Backport 2.7") for the appropriate releases to target.
Only bug and security fixes should be backported, new features should only land in master.