Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nic.members not existing for non-aggregate interfaces. (#1248) #1249

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

sparkiegeek
Copy link
Contributor

Done

  • Add guard for nic.members before checking for nic.members.length

QA

  • Add alias to a single NIC
  • Add alias to a bond
  • Add alias to a bridge

Fixes

Fixes #1248 .

Launchpad Issue

Related Launchpad maas issue in the form lp#number.

Copy link
Contributor

@anthonydillon anthonydillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly an improvement 👍

@anthonydillon anthonydillon self-assigned this Jun 12, 2020
@anthonydillon anthonydillon merged commit fecc2f4 into canonical:master Jun 12, 2020
@sparkiegeek sparkiegeek deleted the fix-single-alias branch June 15, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: nic.members is undefined
2 participants