Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear the redux store when disconnected #1234

Merged
merged 2 commits into from
Jun 11, 2020
Merged

Clear the redux store when disconnected #1234

merged 2 commits into from
Jun 11, 2020

Conversation

huwshimi
Copy link
Contributor

Done

  • Clear the redux store when the websocket gets disconnected.

QA

  • Load the react ui.
  • Restart your maas server.
  • the ui should reconnect and the data in the redux store should be reset (except for auth and status).

Fixes

See: #1222.
See: #1211.

squidsoup
squidsoup approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@squidsoup squidsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@huwshimi huwshimi merged commit f40a25b into canonical:master Jun 11, 2020
This was referenced Jun 11, 2020
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squidsoup squidsoup squidsoup approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huwshimi @squidsoup