Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix form card column sizes. #1232

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Fix form card column sizes. #1232

merged 1 commit into from
Jun 10, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

@Caleb-Ellis Caleb-Ellis commented Jun 10, 2020 •
edited
Loading

Done

  • Fixed col sizes in form cards.
  • Put col sizes into a constants file so we hopefully don't get regressions like this again. Ideally we should be using these constants wherever we have a Col component but for now I've just used them wherever a sidebar might be present.

QA

  • Go to settings, see that the add user form card and delete user expanded rows look good.

Fixes

Fixes canonical-web-and-design/maas-design#907

Screenshot

0 0 0 0_8400_MAAS_r_settings_users

Also updated DHCP snippets form:
2020-06-10_18-59

@Caleb-Ellis Caleb-Ellis force-pushed the fix-form-card-whitespace branch from 5d00609 to 49f33df Compare June 10, 2020 07:40
squidsoup
squidsoup approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@squidsoup squidsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@squidsoup
Copy link
Contributor

One potentially related issue, in contrast to the user form, the dhcp snippets form doesn't extend its fields to the end of the container:

image

Does that look right to you?

@Caleb-Ellis Caleb-Ellis force-pushed the fix-form-card-whitespace branch from f1b04ad to c3932a1 Compare June 10, 2020 08:58
@Caleb-Ellis Caleb-Ellis force-pushed the fix-form-card-whitespace branch from c3932a1 to 4840e21 Compare June 10, 2020 09:00
@Caleb-Ellis Caleb-Ellis merged commit 17f1ab5 into canonical:master Jun 10, 2020
@Caleb-Ellis Caleb-Ellis deleted the fix-form-card-whitespace branch June 10, 2020 09:51
@snyk-bot snyk-bot mentioned this pull request Sep 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squidsoup squidsoup squidsoup approved these changes

Assignees

@squidsoup squidsoup

Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Caleb-Ellis @squidsoup