Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix legacy window titles. #1216

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Fix legacy window titles. #1216

merged 1 commit into from
Jun 9, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

Done

  • Fixed legacy window titles.
  • Renamed root title from "MAAS UI" to "MAAS". I don't think we use "MAAS UI" anywhere else so may as well keep it consistent.

QA

  • Navigate around the legacy angular pages and check that the window title updates correctly.

Fixes

Fixes #1204

squidsoup
squidsoup approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@squidsoup squidsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @Caleb-Ellis!

@Caleb-Ellis Caleb-Ellis merged commit 499a64c into canonical:master Jun 9, 2020
@Caleb-Ellis Caleb-Ellis deleted the fix-window-titles branch June 9, 2020 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squidsoup squidsoup squidsoup approved these changes

Assignees

@squidsoup squidsoup

Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Window title not updating for legacy
2 participants
@Caleb-Ellis @squidsoup