Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remove device interface expanded panel. #1205

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Fix remove device interface expanded panel. #1205

merged 2 commits into from
Jun 4, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

Done

  • Fixed (added? It didn't seem to exist at all) remove device interface expanded panel.

QA

  • Go to the network tab of a device
  • Add an interface with a random MAC address
  • Click the actions dropdown for that interface, select "Remove Physical..." and check that the expanded panel shows
  • Check that you can successfully cancel and perform the action

Fixes

Fixes #1191

anthonydillon
anthonydillon approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@anthonydillon anthonydillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks

@Caleb-Ellis Caleb-Ellis merged commit 5ddc461 into canonical:master Jun 4, 2020
Caleb-Ellis pushed a commit that referenced this pull request Jun 5, 2020
@anthonydillon
Fix remove device interface expanded panel. (#1205)
949cc8e 
Co-authored-by: Anthony Dillon <[email protected]>
@Caleb-Ellis Caleb-Ellis deleted the remove-device-fix branch October 28, 2020 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonydillon anthonydillon anthonydillon approved these changes

Assignees

@anthonydillon anthonydillon

Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove device UI is broken
2 participants
@Caleb-Ellis @anthonydillon