Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build hashes #1190

Merged
merged 6 commits into from
Jun 3, 2020
Merged

Build hashes #1190

merged 6 commits into from
Jun 3, 2020

Conversation

huwshimi
Copy link
Contributor

@huwshimi huwshimi commented Jun 2, 2020

Done

  • Add hashes to the built file names to help with updating caches.
  • Load css files in the single-spa template to improve app loading.

QA

  • Run dotrun, the app should load normally for the react/angular apps.
  • In a local MAAS run the following:
git config --file=.gitmodules submodule.src/maasui/src.url https://github.com/huwshimi/maas-ui.git
git config --file=.gitmodules submodule.src/maasui/src.branch build-hashes
git submodule sync
git submodule update --init --recursive --remote
make clean-ui
make ui

You may have to use SKIP_PREFLIGHT_CHECK=true make ui like I did.

  • The app should load normally for the react/angular apps.
  • There should also be a small improvement to the content flash when switching between apps.

@squidsoup squidsoup linked an issue Jun 3, 2020 that may be closed by this pull request
Copy link
Contributor

@squidsoup squidsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The transitions feel less jarring now, thanks @huwshimi.

@huwshimi huwshimi merged commit 3f58992 into canonical:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firefox does not invalidate MAAS cache with UI update
3 participants