Run the ui as a standalone app #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caleb-Ellis
approved these changes
Jun 1, 2020
There was a problem hiding this comment.
This is awesome, thanks @huwshimi! I'm liking how fast HMR is with the css.
Caleb-Ellis
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
Caleb-Ellis
reviewed
Jun 1, 2020
proxy/package.json
Outdated
| "watch-shared": "cd ../shared && yarn watch" | ||
| }, | ||
| "devDependencies": { | ||
| "concurrently": "5.2.0", | ||
| "cypress": "4.5.0", | ||
| "dotenv-flow": "3.1.0", | ||
| "http-proxy-middleware": "1.0.3", | ||
| "node-sass-tilde-importer": "^1.0.2", |
There was a problem hiding this comment.
Doesn't npm-package-json-lint usually complain about this?
There was a problem hiding this comment.
Yeah, I'm not sure why that didn't complain... I'll fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
dotrun uioryarn ui.