Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VM compose storage capacity input. #1170

Merged
merged 3 commits into from
May 29, 2020
Merged

Fix VM compose storage capacity input. #1170

merged 3 commits into from
May 29, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

@Caleb-Ellis Caleb-Ellis commented May 28, 2020 •
edited
Loading

Done

  • I broke the storage charts when updating the compose form validation because I accidentally changed the input type to text, which screwed with some calculations. This reverts it back to number, and imposes a minimum of 0.
  • Increased the storage cell width so the text doesn't cut off.

QA

  • Open KVM compose form, change the storage values and see that the bar charts match the values.

@Caleb-Ellis Caleb-Ellis merged commit a988f73 into canonical:master May 29, 2020
@Caleb-Ellis Caleb-Ellis deleted the fix-kvm-storage-charts branch October 28, 2020 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squidsoup squidsoup squidsoup approved these changes

Assignees

@squidsoup squidsoup

Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
Iteration 20-22 / May 25 - Jun 5
Development

Successfully merging this pull request may close these issues.
2 participants
@Caleb-Ellis @squidsoup