Remove power fields meant for individual nodes from add chassis form. #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caleb-Ellis
force-pushed
the
chassis-power-fields
branch
from
2319b5a to
4bd8282
Compare
Caleb-Ellis
force-pushed
the
chassis-power-fields
branch
from
eb3782d to
7e6b7ad
Compare
huwshimi
approved these changes
May 7, 2020
| // When adding a chassis we need only a subset of fields that aren't specific | ||
| // to individual nodes. | ||
| const fields = forChassis | ||
| ? powerTypeFields.filter((field) => field.scope !== "node") |
There was a problem hiding this comment.
As far as I can tell the scopes are either "node" or "bmc". If a third type was added would this filter still be correct? Or would we only want the fields that are scoped to "bmc"?
There was a problem hiding this comment.
I'm not sure to be honest. I know for certain we don't want "node" scopes, and the only two scopes are "node" and "bmc". But whether or not an extra scope might include chassis will depend on the core team keeping us in the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
scope: "node"are now filtered from add chassis form.trimPowerParameterstoformatPowerParameters- now it acts as a bit of an integration layer between Formik and the add machine/add chassis apis (scanned the maas code and found that the add chassis api expects different parameters names than add machine).QA
chassis: trueand the fields are filtered byscope: "bmc"according tostate.general.powerTypes.data.chassis: truewhen they shouldn't be so you might get an error that the power type is not for chassis.Fixes
Fixes #1084
Launchpad Issue
1876680