Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tag selector margin. #1080

Merged
merged 3 commits into from
May 4, 2020
Merged

Fix tag selector margin. #1080

merged 3 commits into from
May 4, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

Done

  • Added margin back to tag selector input, subtracted it from tag selector dropdown.

QA

  • Select some machines and choose "Tag" from the action dropdown
  • Resize screen to small and check there is space between the tag selector and the submit button

Fixes

Fixes canonical-web-and-design/MAAS-squad#1910

@Caleb-Ellis Caleb-Ellis merged commit 9afbdc0 into canonical:master May 4, 2020
@Caleb-Ellis Caleb-Ellis deleted the tag-selector-margin branch May 4, 2020 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huwshimi huwshimi huwshimi approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Caleb-Ellis @huwshimi