Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise an error for unused variables. #1079

Merged
merged 1 commit into from
May 4, 2020
Merged

Raise an error for unused variables. #1079

merged 1 commit into from
May 4, 2020

Conversation

huwshimi
Copy link
Contributor

@huwshimi huwshimi commented May 4, 2020

Done

  • Raise an error for unused variables.
  • Re-enable accessibility lint. Replace labels that have no form inputs.

Caleb-Ellis
Caleb-Ellis approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@Caleb-Ellis Caleb-Ellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@huwshimi huwshimi merged commit 246a63f into canonical:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Caleb-Ellis Caleb-Ellis Caleb-Ellis approved these changes

Assignees
No one assigned
Labels
Review: Code +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huwshimi @Caleb-Ellis