Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix processing state #1074

Merged
merged 3 commits into from
May 4, 2020
Merged

Fix processing state #1074

merged 3 commits into from
May 4, 2020

Conversation

huwshimi
Copy link
Contributor

@huwshimi huwshimi commented May 1, 2020

Done

  • Prevent the "update your selection" notice from appearing once machines have begun to be processed. This was causing a bug as when the machines begin to be changed they can change the allowable actions from that machine, resulting in that machine being shown.

QA

  • Selecting a number of new machines (at least 5).
  • Using the take action menu select "Commission" and submit the form.
  • The machines should transition to commissioning and the "update your selection" warning should not appear.
  • You might have to do this a few times (you can abort once they transition to commissioning) to be satisfied this is fixed.

Fixes

Fixes: https://github.com/canonical-web-and-design/MAAS-squad/issues/1897.

@huwshimi huwshimi force-pushed the fix-processing-warning branch from ca70a5d to 4a9b3da Compare May 1, 2020 06:49
Caleb-Ellis
Caleb-Ellis approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@Caleb-Ellis Caleb-Ellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just need to fix one test

ui/src/app/machines/components/HeaderStrip/ActionFormWrapper/ActionFormWrapper.test.js Outdated
</Provider>,
{ context: store }
);
// act(() => wrapper.find("CommissionForm").props().setProcessing(true));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to uncomment this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, thanks, removed.

huwshimi added 2 commits May 4, 2020 12:01
@huwshimi
Track processing state so that the update-your-selection notice doesn…
7d927d2 
…'t occasionally appear when machines change what actions are available to them.
@huwshimi
Remove unused act.
76be41b
@huwshimi huwshimi force-pushed the fix-processing-warning branch from 4a9b3da to 76be41b Compare May 4, 2020 02:02
@huwshimi huwshimi merged commit 33f913f into canonical:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Caleb-Ellis Caleb-Ellis Caleb-Ellis approved these changes

Assignees
No one assigned
Labels
Review: Code +1 (with changes) Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huwshimi @Caleb-Ellis