Update OverrideFailedTestForm formatting and warning text. #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huwshimi
requested changes
May 1, 2020
...c/app/machines/components/HeaderStrip/ActionFormWrapper/OverrideTestForm/OverrideTestForm.js
Outdated
Show resolved
Hide resolved
.../machines/components/HeaderStrip/ActionFormWrapper/OverrideTestForm/OverrideTestForm.test.js
Outdated
Show resolved
Hide resolved
Caleb-Ellis
force-pushed
the
override-form-format
branch
2 times, most recently
from
f3631ab to
f4843ab
Compare
huwshimi
approved these changes
May 1, 2020
| <a | ||
| href={`${process.env.REACT_APP_BASENAME}/#/machine/${singleMachine.system_id}`} | ||
| > | ||
| {` failed ${numFailedTests} ${pluralize("test", numFailedTests)}.`} |
There was a problem hiding this comment.
One further dedupe, you could store this as a string and append have below.
Caleb-Ellis
force-pushed
the
override-form-format
branch
from
f4843ab to
d9c6e29
Compare
Caleb-Ellis
force-pushed
the
override-form-format
branch
from
d9c6e29 to
4a84c1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
Fixes
Fixes canonical-web-and-design/MAAS-squad#1902
Screenshots
Multiple non-failed
Single non-failed
Multiple failed
Single failed