Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't persist the selected state in the URL #1066

Merged
merged 3 commits into from
Apr 30, 2020
Merged

Don't persist the selected state in the URL #1066

merged 3 commits into from
Apr 30, 2020

Conversation

huwshimi
Copy link
Contributor

Done

  • Don't store the in:selected/!selected state in the URL.

QA

  • Go to the machine list and type in:selected in the search box. It should not be reflected in the URL.

Fixes

Fixes: #1057.

squidsoup
squidsoup approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@squidsoup squidsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@huwshimi huwshimi merged commit 037cc6a into canonical:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squidsoup squidsoup squidsoup approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't persist selected filter
2 participants
@huwshimi @squidsoup