-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency jquery to v3.5.0 [SECURITY] #1062
Conversation
232bcd1
to
2678d62
Compare
2678d62
to
21856a7
Compare
PR has been edited👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description. |
QAPlease QA this thoroughly (ensure this hasn't broken any views in the angular app). I've audited the code for problematic self closing tags, and could only find one. |
@@ -1,5 +1,5 @@ | |||
<div ng-if="loading"> | |||
<i class="p-icon--spinner u-animation--spin" /> | |||
<i class="p-icon--spinner u-animation--spin"></i> | |||
Loading... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grepping the code, this was the only remaining instance of a potentially problematic self closing tag I could find, other than input
s, hr
s and br
s, but perhaps have a quick grep when QAing this to ensure I haven't missed anything.
I've added a card to make sure we don't forget to backport this. |
* Update dependency jquery to v3.5.0 [SECURITY] * Fix self closing i tag.
* Update dependency jquery to v3.5.0 [SECURITY] * Fix self closing i tag.
This PR contains the following updates:
3.4.1
->3.5.0
GitHub Vulnerability Alerts
CVE-2020-11023
Impact
Passing HTML containing
<option>
elements from untrusted sources - even after sanitizing it - to one of jQuery's DOM manipulation methods (i.e..html()
,.append()
, and others) may execute untrusted code.Patches
This problem is patched in jQuery 3.5.0.
Workarounds
To workaround this issue without upgrading, use DOMPurify with its
SAFE_FOR_JQUERY
option to sanitize the HTML string before passing it to a jQuery method.References
https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/
For more information
If you have any questions or comments about this advisory, search for a relevant issue in the jQuery repo. If you don't find an answer, open a new issue.
CVE-2020-11022
Impact
Passing HTML from untrusted sources - even after sanitizing it - to one of jQuery's DOM manipulation methods (i.e.
.html()
,.append()
, and others) may execute untrusted code.Patches
This problem is patched in jQuery 3.5.0.
Workarounds
To workaround the issue without upgrading, adding the following to your code:
You need to use at least jQuery 1.12/2.2 or newer to be able to apply this workaround.
References
https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/
https://jquery.com/upgrade-guide/3.5/
For more information
If you have any questions or comments about this advisory, search for a relevant issue in the jQuery repo. If you don't find an answer, open a new issue.
Release Notes
jquery/jquery
v3.5.0
Compare Source
Renovate configuration
📅 Schedule: "" (UTC).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.