Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine available and selected machine strings. #1059

Merged
merged 1 commit into from
May 1, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

@Caleb-Ellis Caleb-Ellis commented Apr 29, 2020

Done

QA

  • See that the text next to machines reads "Y machines available"
  • Select some machines and check that the text is now a "button" link that reads "X of Y machines selected"
  • Click the button and check the machine list is filtered to selected machines
  • Remove filter, select all machines and check that the text reads "All machines selected"

Fixes canonical-web-and-design/MAAS-squad#1891
Fixes canonical-web-and-design/MAAS-squad#1894

Screenshots

None

Screenshot_2020-04-29 Machines bolla MAAS(1)

Some

Screenshot_2020-04-29 Machines bolla MAAS(2)

Filtered

Screenshot_2020-04-29 Machines bolla MAAS(3)

All

Screenshot_2020-04-29 Machines bolla MAAS(4)

@lilyvidenova
Copy link

I reaaally like this! Only one little thing - when I deselect the all checkbox in the header, the list is empty because we're still searching for in:selected
image.png

Can we clear the filter when you deselect the checkbox? Other than that +1 from me!

@lilyvidenova
Copy link

@lyubomir-popov wanna take a look?

@lyubomir-popov
Copy link
Contributor

@lilyvidenova sure

@lyubomir-popov lyubomir-popov self-assigned this Apr 30, 2020
@lyubomir-popov
Copy link
Contributor

lyubomir-popov commented Apr 30, 2020

@Caleb-Ellis Does clicking on the link in the header filter to only show the selected ones? That would be really handy. If it does, maybe just the number 13 should be a link?

Well done! +1

@lyubomir-popov lyubomir-popov removed their assignment Apr 30, 2020
@lilyvidenova
Copy link

@lyubomir-popov yes, this all this branch does

@lyubomir-popov
Copy link
Contributor

Yeah, should've checked the code before asking.
@lilyvidenova Do you think the whole thing should be clickable - or just eh 13 part?

@huwshimi
Copy link
Contributor

I reaaally like this! Only one little thing - when I deselect the all checkbox in the header, the list is empty because we're still searching for in:selected

Can we clear the filter when you deselect the checkbox? Other than that +1 from me!

I fixed this in #1065 (this branch is a bit behind master).

@Caleb-Ellis Caleb-Ellis changed the title Demo: x of y machines selected link in machine list header. Combine available and selected machine strings. Apr 30, 2020
@Caleb-Ellis Caleb-Ellis force-pushed the selected-machines branch from 841eaa9 to 9cb2d59 Compare May 1, 2020 05:43
Copy link
Contributor

@huwshimi huwshimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of lint errors to fix.

@Caleb-Ellis Caleb-Ellis force-pushed the selected-machines branch from 48ed587 to 6ee954e Compare May 1, 2020 06:14
@Caleb-Ellis Caleb-Ellis merged commit 7354c81 into canonical:master May 1, 2020
@Caleb-Ellis Caleb-Ellis deleted the selected-machines branch May 1, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants