Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LXD radio option to Add KVM form. #1051

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

@Caleb-Ellis Caleb-Ellis commented Apr 28, 2020

Done

  • Added LXD radio option to Add KVM form, so you can choose between virsh and LXD.
  • Driveby - remove ability to select more than one storage pool when composing machines from LXD pod.
  • Driveby - increase delay when hackily updating pod machine list with newly composed machine. When testing composing machines from a LXD pod it wouldn't show up sometimes

QA

  • Go to /kvm and select Add KVM from the top right
  • Check that the form matches the design, noting that the copy will be added later.
  • Go to /rsd and check that the form there remains as before.
  • Go to the bolla lxd pod and compose machine
  • Check that you can only choose one storage pool.
  • Compose a machine and check that the pod machine list updates correctly.

Fixes

Fixes canonical-web-and-design/MAAS-squad#1918
Fixes #1017

Screenshot

Screenshot_2020-04-28 KVM bolla MAAS

@Caleb-Ellis
Copy link
Contributor Author

@lilyvidenova I've added UX needed just to check if the copy for the help text is still not ready, so we'll add it in a follow up later on?

@Caleb-Ellis
Copy link
Contributor Author

Adding UX + 1 to confirm copy is to come later

@Caleb-Ellis Caleb-Ellis merged commit 9511b12 into canonical:master Apr 29, 2020
@Caleb-Ellis Caleb-Ellis deleted the lxd-virsh-pods branch April 29, 2020 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only allow one storage device when using/creating LXD pods
2 participants