Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Loader in paragraph error #1035

Merged
merged 2 commits into from
Apr 26, 2020
Merged

Fix Loader in paragraph error #1035

merged 2 commits into from
Apr 26, 2020

Conversation

huwshimi
Copy link
Contributor

Done

  • Upgrade React Components.
  • Replace Loader with Spinner.

QA

  • Visit /r/machines.
  • Select some machines.
  • Using the take action menu select the option to change the pool.
  • Select a pool (or create a new one).
  • A spinner should appear with the status of the machines.
  • In your console there shouldn't be an error about a div not being allowed in a p.

@huwshimi huwshimi closed this Apr 24, 2020
@huwshimi huwshimi force-pushed the fix-spinner-div-error branch from b78b4ed to cf82332 Compare April 24, 2020 09:45
@huwshimi huwshimi reopened this Apr 24, 2020
@huwshimi huwshimi force-pushed the fix-spinner-div-error branch from 6affa8f to 0fdd085 Compare April 24, 2020 09:59
@huwshimi huwshimi force-pushed the fix-spinner-div-error branch from 0fdd085 to c4c41cf Compare April 24, 2020 10:15
@anthonydillon anthonydillon self-assigned this Apr 24, 2020
@anthonydillon
Copy link
Contributor

Code looks good. I am not seeing a spinner when changing a pool. It takes about 5 seconds and then the pool changes in the list. Am I missing something?

@anthonydillon
Copy link
Contributor

Sorry missed the clean and rebuild step. I see it now 👍

@huwshimi huwshimi merged commit dc9ec5c into canonical:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Caleb-Ellis Caleb-Ellis Caleb-Ellis approved these changes

Assignees

@anthonydillon anthonydillon

Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huwshimi @anthonydillon @Caleb-Ellis