Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix machine list checkbox behaviour. #1026

Merged
merged 2 commits into from
Apr 24, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

@Caleb-Ellis Caleb-Ellis commented Apr 24, 2020

Done

  • Disabled all machine checkbox if there are not machines in the list.
  • Removed all instances of machine list checkboxes being disabled.
  • Filter out zone and pool in-table actions if they can't be performed on the machine.
  • Removed p-button--link is-inline margin so the "Update your selection" text doesn't look weird.
  • Removed extra "." in override failed test message.
  • Fixed wonky fabric test failed tooltip.

QA

  • Lock a machine
  • Check that the in-table action for pool and zone have a message saying you can't change them
  • Check that you can still select the machine and unlock it from the in-table action and global action menu.
  • Select a bunch of machines that aren't all "Failed testing" and choose "Override failed testing" from the global take action menu.
  • Check that the "Update your selection" text looks good.
  • Filter all machines and check that the all checkbox is unchecked and disabled.

Fixes

Fixes #972
Fixes #1006
Fixes #1014
Fixes #1024

@Caleb-Ellis Caleb-Ellis merged commit 430da6f into canonical:master Apr 24, 2020
@Caleb-Ellis Caleb-Ellis deleted the checkbox-fixes branch April 24, 2020 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment