Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors in the take action forms #1025

Merged
merged 4 commits into from
Apr 24, 2020
Merged

Handle errors in the take action forms #1025

merged 4 commits into from
Apr 24, 2020

Conversation

huwshimi
Copy link
Contributor

Done

  • Handle errors for the take action menu forms

QA

  • Using the take action menu do a bunch of actions that will fail, you should get errors displayed.

Fixes

Fixes: #984.
Fixes: #1001.

Caleb-Ellis
Caleb-Ellis approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@Caleb-Ellis Caleb-Ellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@huwshimi huwshimi merged commit 10ad1e2 into canonical:master Apr 24, 2020
@snyk-bot snyk-bot mentioned this pull request Dec 19, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Caleb-Ellis Caleb-Ellis Caleb-Ellis approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Action menu - handle errors Handle errors and saving state for creating a pool
2 participants
@huwshimi @Caleb-Ellis